This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
Fixing bugs for HATS. #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng now (Travis is having HTTP issues).
|
The Uproot HATS is done, so I'll close off this PR and give it a version number. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first of these is a long-held oversight: Uproot has never been able to read @sbinet's small-evnt-tree-nosplit.root. Unsplit objects are much harder, so maybe this was justified in the beginning, but now I wanted to show the same example in split and unsplit form, for which small-evnt-tree-fullsplit.root and small-evnt-tree-nosplit.root provide a good example.
The two bugs that had to be fixed were:
landLdon't correspond tolongandunsigned long; they're both 32-bits. Different platforms make similarly different interpretations. For 64-bit non-Windows, at least, the data should be deserialized as 64-bit, so we use Python'sqandQ.std::vector<std::string>wasn't implemented for unsplit objects. The implementation is easy.