This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses @HDembinski 's comment - https://github.com/scikit-hep/uproot/pull/477/files#r419114287
@jpivarski should I also rename the corresponding attribute used internally like I did in b022cb9 ? I am a little hesitant because size could mean other things.
There are 3 possibilities in my mind -
size
parameter and then do abranch.size = ..
to change it._iscounter
class variable) with 'size'.Which one do you prefer?