Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Rename counter to size in TBranch UI #481

Merged
merged 1 commit into from
May 4, 2020
Merged

Rename counter to size in TBranch UI #481

merged 1 commit into from
May 4, 2020

Conversation

reikdas
Copy link
Collaborator

@reikdas reikdas commented May 4, 2020

Addresses @HDembinski 's comment - https://github.com/scikit-hep/uproot/pull/477/files#r419114287

@jpivarski should I also rename the corresponding attribute used internally like I did in b022cb9 ? I am a little hesitant because size could mean other things.

There are 3 possibilities in my mind -

  1. Leave it as it is (the current state of this PR).
  2. Just rename the newbranch class' size attribute (and all references to it) so that users could first create the branch without specifying the size parameter and then do a branch.size = .. to change it.
  3. Replace all occurrences of 'counter' in the codebase(including the _iscounter class variable) with 'size'.

Which one do you prefer?

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Thanks!

@jpivarski jpivarski merged commit 33b9d55 into master May 4, 2020
@jpivarski jpivarski deleted the rename-counter branch May 4, 2020 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants