Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Read RNTuple anchor #471

Merged
merged 3 commits into from
May 4, 2020
Merged

Read RNTuple anchor #471

merged 3 commits into from
May 4, 2020

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski
Copy link
Member Author

Commit 317c6c4 was unintentionally added, but it's not a problem. We wanted to bump the version number anyway.

@jpivarski
Copy link
Member Author

@oshadura This PR passes tests, but I can keep it open in case you run into anything else that needs to be fixed at the uproot level, anything that could help you figure out how to deserialize RNTuple in Python. If, on the other hand, you think this is all that's necessary, I can merge it so that you can work from a released version.

@oshadura
Copy link
Contributor

oshadura commented May 4, 2020

Hi Jim! I realized that the easiest way is to make a rntuple reader as a dependency of uproot, but I can't proceed without your PR :) (particularly without rntuple defined in builtin_classes).

@jpivarski
Copy link
Member Author

I can't believe I forgot to merge this. I'll also deploy a version soon.

@jpivarski jpivarski merged commit 820049c into master May 4, 2020
@jpivarski jpivarski deleted the read_rntuple_anchor branch May 4, 2020 15:41
@oshadura
Copy link
Contributor

oshadura commented May 4, 2020 •
edited
Loading

Wonderful, now I can go ahead full speed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpivarski @oshadura