Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Allow dtypes with byteorders via lists. Fixes #434 #435

Merged
merged 2 commits into from
Jan 11, 2020
Merged

Allow dtypes with byteorders via lists. Fixes #434 #435

merged 2 commits into from
Jan 11, 2020

Conversation

tamasgal
Copy link
Contributor

This patch fixes the byte order interpretation of dtypes which are passed as lists. The current implementation ignores them and falls back to big endian in case of the ROOT data (fromdtype) and native for the Python side (todtype).

Note that the workaround is to pass numpy.dtype instances, which works fine, so this patch is more like cosmetics, but can potentially prevent some confusion in future.

@tamasgal tamasgal mentioned this pull request Jan 11, 2020
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see—so if an explicit byte order is passed, we take it seriously, even if it's in a record dtype. That sounds like a missing case for a previously intended behavior.

When you give an explicit "merge it now" and all tests pass, I'll merge it.

@tamasgal
Copy link
Contributor Author

Great, yes please merge then 😉

@jpivarski jpivarski merged commit f3d0cc6 into scikit-hep:master Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants