This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
Allow dtypes with byteorders via lists. Fixes #434 #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the byte order interpretation of dtypes which are passed as
list
s. The current implementation ignores them and falls back to big endian in case of the ROOT data (fromdtype
) and native for the Python side (todtype
).Note that the workaround is to pass
numpy.dtype
instances, which works fine, so this patch is more like cosmetics, but can potentially prevent some confusion in future.