Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Get pytest-error-for-skips from PyPI #428

Merged
merged 2 commits into from
Dec 20, 2019

Conversation

chrisburr
Copy link
Member

I wasn't expecting my PR to fix pytest-error-for-skips to be accepted as it hadn't been updated in years but it has been so we can now get it from PyPI.

Also skips test_issue390 if pandas is unavailable.

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see what this is now. When @reikdas pointed me to that pip install of a GitHub repo, it looked very fragile to me. I must have accepted it without noticing. I also didn't understand the purpose of it, but now that I see it here, I see why you did that. I'm definitely in favor of more explicit (and reported) skipping.

I'll merge that's if you're done. Just give me confirmation.

@chrisburr
Copy link
Member Author

chrisburr commented Dec 20, 2019

Yeah, I'm very happy the maintainer jumped in to make a new release as it seems like a useful little package. I'd normally say it was too small to justify a dependency but as it's only for the CI I think it makes sense.

I'm done so go ahead and merge!

@jpivarski jpivarski merged commit c0a6c2e into scikit-hep:master Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants