Provide method to get ROOT class names as plain strings #379

masonproffitt · 2019-10-16T14:36:59Z

Try to provide a convenient and consistent method to retrieve ROOT class names as plain strings

jpivarski

My suggested implementations should work in your new tests (see line comments).

uproot/rootio.py

Require that classname functions work on both classes and instances

…ave some 'classname' accessors be without parentheses and some with; the code can be a little more WET to save the user some confusion.

jpivarski · 2019-11-02T20:21:56Z

If you want to talk about this before I merge it, find me today!

uproot/rootio.py

jpivarski · 2019-11-03T02:17:46Z

Are you happy with me merging this?

masonproffitt · 2019-11-03T06:37:44Z

Yeah, this looks fine to me.

masonproffitt added 2 commits October 16, 2019 16:25

add test for classname() and classnames()

d25dfba

add classname() and classnames()

24875e4

Try to provide a convenient and consistent method to retrieve ROOT class names as plain strings

jpivarski reviewed Oct 16, 2019

View reviewed changes

uproot/rootio.py Outdated Show resolved Hide resolved

uproot/rootio.py Outdated Show resolved Hide resolved

masonproffitt and others added 5 commits October 17, 2019 11:52

update tests for scikit-hep#376

d475e3f

Require that classname functions work on both classes and instances

update tests for scikit-hep#376

67e01f6

make classname functions consistent with classes()

8be558d

Merge branch 'master' into issue376

768f78e

I'd rather add a 'classname' attribute to every class manually than h…

611308f

…ave some 'classname' accessors be without parentheses and some with; the code can be a little more WET to save the user some confusion.

masonproffitt commented Nov 3, 2019

View reviewed changes

uproot/rootio.py Outdated Show resolved Hide resolved

jpivarski added 2 commits November 3, 2019 11:58

Fix TArrayC

aa829d1

Give streamers and TKeys , too.

93a2956

jpivarski merged commit 7052188 into scikit-hep:master Nov 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide method to get ROOT class names as plain strings #379

Provide method to get ROOT class names as plain strings #379

masonproffitt commented Oct 16, 2019

jpivarski left a comment

jpivarski commented Nov 2, 2019

jpivarski commented Nov 3, 2019

masonproffitt commented Nov 3, 2019

Provide method to get ROOT class names as plain strings #379

Provide method to get ROOT class names as plain strings #379

Conversation

masonproffitt commented Oct 16, 2019

jpivarski left a comment

Choose a reason for hiding this comment

jpivarski commented Nov 2, 2019

jpivarski commented Nov 3, 2019

masonproffitt commented Nov 3, 2019