Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Resize all other branches when one branch overflows #368

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Resize all other branches when one branch overflows #368

merged 1 commit into from
Oct 5, 2019

Conversation

reikdas
Copy link
Collaborator

@reikdas reikdas commented Oct 4, 2019

Fixes #345

@reikdas reikdas requested a review from jpivarski October 4, 2019 19:09
@reikdas reikdas mentioned this pull request Oct 4, 2019
Closed
jpivarski
jpivarski approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this demonstrably reduce the number of TTree-metadata rewrites when the number of branches is large? Have you tested it?

@reikdas
Copy link
Collaborator Author

reikdas commented Oct 4, 2019

Does this demonstrably reduce the number of TTree-metadata rewrites when the number of branches is large? Have you tested it?

Yes. In my tests, it reduces the size of the file from 10+ GB(I stopped the program execution at that point) to 4.5 GB.

@jpivarski
Copy link
Member

Okay, good. (This is the important thing.)

I restarted the one PyPy job that failed; it was probably an error in downloading the dependencies or something.

@reikdas reikdas merged commit d088caa into master Oct 5, 2019
@reikdas reikdas deleted the issue345 branch October 5, 2019 03:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

root file, written with uproot, size issue
2 participants
@reikdas @jpivarski