Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Fix issue340 #343

Merged
merged 4 commits into from
Sep 20, 2019
Merged

Fix issue340 #343

merged 4 commits into from
Sep 20, 2019

Conversation

reikdas
Copy link
Collaborator

@reikdas reikdas commented Sep 20, 2019

Fixes #340
My understanding of the fLast attribute of the TKey of TBaskets was wrong.
Added some more tests.

@reikdas reikdas force-pushed the issue340 branch 2 times, most recently from ff5418e to 4086af6 Compare September 20, 2019 06:33
@reikdas reikdas changed the title Fix issue340 [WIP]Fix issue340 Sep 20, 2019
@reikdas reikdas changed the title [WIP]Fix issue340 Fix issue340 Sep 20, 2019
@jpivarski
Copy link
Member

Let me know when you think this is done and want it to be merged. Thanks!

@reikdas
Copy link
Collaborator Author

reikdas commented Sep 20, 2019

It is done and can be merged once all the tests pass :)

@jpivarski
Copy link
Member

Great! I'll do that (once the tests pass) and you can tell Matthieu that it's fixed, if you haven't already. (Has the version number been bumped? If so, I'll make a new release as well.)

@reikdas
Copy link
Collaborator Author

reikdas commented Sep 20, 2019

and you can tell Matthieu that it's fixed, if you haven't already.

I'll comment on the issue once this PR has been merged.

(Has the version number been bumped? If so, I'll make a new release as well.)

Yes :)
(Note - I made another PR today where I did not bump the version number, so if that get merged there could be just one release with both the changes?)

@jpivarski
Copy link
Member

I didn't realize there was another PR. Maybe it would be easier if you merge both, draft a release, and then point me to the draft?

@reikdas reikdas merged commit 1e0953f into master Sep 20, 2019
@reikdas reikdas deleted the issue340 branch September 20, 2019 10:38
@reikdas
Copy link
Collaborator Author

reikdas commented Sep 20, 2019

I have drafted a release (https://github.com/scikit-hep/uproot/releases) but perhaps we should wait till I add the fix for append? It is trivial and I should get it done very soon.

@jpivarski
Copy link
Member

Sure, I'll wait. Just let me know when.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reading with uproot root files, with TTree, written with uproot
2 participants