-
Notifications
You must be signed in to change notification settings - Fork 67
Fix issue340 #343
Fix issue340 #343
Conversation
ff5418e
to
4086af6
Compare
Let me know when you think this is done and want it to be merged. Thanks! |
It is done and can be merged once all the tests pass :) |
Great! I'll do that (once the tests pass) and you can tell Matthieu that it's fixed, if you haven't already. (Has the version number been bumped? If so, I'll make a new release as well.) |
I'll comment on the issue once this PR has been merged.
Yes :) |
I didn't realize there was another PR. Maybe it would be easier if you merge both, draft a release, and then point me to the draft? |
I have drafted a release (https://github.com/scikit-hep/uproot/releases) but perhaps we should wait till I add the fix for append? It is trivial and I should get it done very soon. |
Sure, I'll wait. Just let me know when. |
Fixes #340
My understanding of the fLast attribute of the TKey of TBaskets was wrong.
Added some more tests.