Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Fixed extend for flush=True #342

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Fixed extend for flush=True #342

merged 1 commit into from
Sep 20, 2019

Conversation

reikdas
Copy link
Collaborator

@reikdas reikdas commented Sep 20, 2019

Fixes extend with flush=True (even though it is still using the inefficient implementation of flush=False).
Even after the better(and correct) implementation of flush=False for extend, the code under the flush=True block should probably not change.

Although, in its current implementation this makes extend=True less efficient, the implementation is now correct.

@jpivarski
Copy link
Member

Ah—this is the other PR.

@reikdas reikdas merged commit 41068e3 into master Sep 20, 2019
@reikdas reikdas deleted the extend-fix branch September 20, 2019 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants