Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use newer setuptools_scm for versioning #94

Merged
merged 12 commits into from
Jun 19, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 19, 2021

This bumps us up to a more modern version of setuptools_scm that supports pyproject.toml and will inject the right version at build time (via PEP517/8) as well as generate the corresponding version.py for us at build time.

c.f. scikit-hep/pyhf#1450 for motivation

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update to a modern version of setuptools_scm to support pyproject-based Python packages
   - Use local_scheme = "no-local-version" to continue uploading to TestPyPI
   - c.f. https://github.com/pypa/setuptools_scm/blob/v6.0.1/README.rst#version-number-construction
* Add `pylhe.__version__` to API
* Generate src/pylhe/_version.py at build time
   - Remove setup.cfg from bump2version control
* Set fetch depth:0 in CI to get full history and tags to generate version number
   - c.f. https://github.com/scikit-hep/pyhf/issues/1465

@matthewfeickert matthewfeickert force-pushed the chore/use-new-setuptools branch from 627e42a to 67b6d94 Compare June 19, 2021 23:09
@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #94 (2fb67ac) into master (34c4b8c) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   60.69%   60.89%   +0.19%     
==========================================
  Files           2        2              
  Lines         201      202       +1     
  Branches       36       36              
==========================================
+ Hits          122      123       +1     
  Misses         72       72              
  Partials        7        7              
Flag Coverage Δ
unittests 60.89% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pylhe/__init__.py 66.66% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c4b8c...2fb67ac. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 909f513 into master Jun 19, 2021
@matthewfeickert matthewfeickert deleted the chore/use-new-setuptools branch June 19, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant