Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update examples/awkward_example.ipynb #174

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

eduardo-rodrigues
Copy link
Member

Closes #120.

@eduardo-rodrigues eduardo-rodrigues added the docs Documentation related label Jan 3, 2023
@eduardo-rodrigues eduardo-rodrigues self-assigned this Jan 3, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 85.71% // Head: 85.71% // No change to project coverage 👍

Coverage data is based on head (e5c5401) compared to base (3a0590d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files           2        2           
  Lines         217      217           
  Branches       48       48           
=======================================
  Hits          186      186           
  Misses         27       27           
  Partials        4        4           
Flag Coverage Δ
unittests-3.10 85.25% <ø> (ø)
unittests-3.7 84.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eduardo-rodrigues
Copy link
Member Author

Happy New Year @matthewfeickert!

This was low-hanging fruit. I would make a (legacy) release just after this, to then move to depending on awkward 2. Let me know what you think.

@matthewfeickert matthewfeickert merged commit 3b8571d into master Jan 4, 2023
@matthewfeickert matthewfeickert deleted the eduardo-issue-120 branch January 4, 2023 07:03
@matthewfeickert
Copy link
Member

Happy New Year

Same to you! Hope 2023 is off to a good start. 🎉

This was low-hanging fruit. I would make a (legacy) release just after this, to then move to depending on awkward 2. Let me know what you think.

Sounds good. We had discussed doing a v0.5.0 release awhile back, but I had wanted to get PR #157 fixed and in before doing so. I'm not sure why it is failing at the moment and haven't made time to circle back to fix it. If you have any thoughts there that would be nice to knock out.

@eduardo-rodrigues
Copy link
Member Author

Sure, am on it ... :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running master/examples/
2 participants