Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more homogeneous usage of ParseError #141

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Conversation

eduardo-rodrigues
Copy link
Member

I noticed that the read_lhe type of functions and others, which parse the XML, do not all catch parsing errors. This PR makes things more homogeneous. Note that

  1. On purpose I am not trying here to deal with test coverage of these parsing errors. That's something to be done with a dedicated PR and will require a special LHE file, if not several.
  2. We should discuss at some point if parsing errors should raise errors or be dealt with smoothly, as now, with print statements. Again, I think it is better to make any modification to the way these errors are dealt with homogeneously across the various methods.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 68.07% // Head: 67.28% // Decreases project coverage by -0.79% ⚠️

Coverage data is based on head (1e0bcf4) compared to base (e7faf40).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   68.07%   67.28%   -0.80%     
==========================================
  Files           2        2              
  Lines         213      217       +4     
  Branches       57       57              
==========================================
+ Hits          145      146       +1     
- Misses         61       64       +3     
  Partials        7        7              
Flag Coverage Δ
unittests-3.10 65.89% <50.00%> (-0.77%) ⬇️
unittests-3.6 64.62% <50.00%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pylhe/__init__.py 73.88% <50.00%> (-1.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eduardo-rodrigues
Copy link
Member Author

This is ready given the scope, see description. Merging as I have tests in the pipeline to be added.

@eduardo-rodrigues eduardo-rodrigues merged commit c16fe99 into master Aug 30, 2022
@eduardo-rodrigues eduardo-rodrigues deleted the eduardo-feat-1 branch August 30, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant