Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [pre-commit.ci] pre-commit autoupdate #107

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jan 3, 2022

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.1.0](pre-commit/pre-commit-hooks@v4.0.1...v4.1.0)
- [github.com/asottile/pyupgrade: v2.29.1 → v2.31.0](asottile/pyupgrade@v2.29.1...v2.31.0)
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #107 (58e5f98) into master (f4c2bc3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files           2        2           
  Lines         202      202           
  Branches       55       55           
=======================================
  Hits          122      122           
  Misses         72       72           
  Partials        8        8           
Flag Coverage Δ
unittests 60.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c2bc3...58e5f98. Read the comment docs.

Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as admin colleague since a no-brainer :-).

@eduardo-rodrigues eduardo-rodrigues merged commit af3d209 into master Jan 7, 2022
@eduardo-rodrigues eduardo-rodrigues deleted the pre-commit-ci-update-config branch January 7, 2022 11:34
@matthewfeickert
Copy link
Member

Approving as admin colleague since a no-brainer :-).

I was going to come back to this after I was back from break, as now the pyupgrade additional dependencies are out of sync.

additional_dependencies: [pyupgrade==2.29.1]

@matthewfeickert
Copy link
Member

I was going to come back to this after I was back from break, as now the pyupgrade additional dependencies are out of sync.

Though now this gives an opportunity to switch over to black-jupyter in PR #109. 🙂

matthewfeickert added a commit that referenced this pull request Jan 7, 2022
…hook (#109)

* Use black-jupyter hook over nbqa-black
* Sync pre-commit additional_dependencies for pyupgrade
   - Amends PR #107
@eduardo-rodrigues
Copy link
Member

Ah, sorry for this annoyance. Trying to help ... Indeed I missed that subtletly of the one file that is not updated by the bot. Will try and keep that in mind.

@matthewfeickert
Copy link
Member

Ah, sorry for this annoyance. Trying to help ... Indeed I missed that subtletly of the one file that is not updated by the bot. Will try and keep that in mind.

Nothing to be sorry about! This is one of those small subtleties with pre-commit that can get tricky to keep in sync (and is apparently difficult to do programatically as it was deemed way too hard by the authors to add in when I asked about it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants