Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow "name" attribute of weightgroup #106

Closed
wants to merge 3 commits into from

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented Dec 11, 2021

Resolves #76

  * take the weightgroup's type from the "name" attribute if it is given instead of the "type" attribute.

@matthewfeickert matthewfeickert force-pushed the weightgroupByName branch 2 times, most recently from 7503b9b to 7cc18b5 Compare April 5, 2022 06:03
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Base: 67.28% // Head: 61.57% // Decreases project coverage by -5.70% ⚠️

Coverage data is based on head (49dbef8) compared to base (c16fe99).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 49dbef8 differs from pull request most recent head 04bc3aa. Consider uploading reports for the commit 04bc3aa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   67.28%   61.57%   -5.71%     
==========================================
  Files           2        2              
  Lines         217      203      -14     
  Branches       57       57              
==========================================
- Hits          146      125      -21     
- Misses         64       68       +4     
- Partials        7       10       +3     
Flag Coverage Δ
unittests-3.10 60.09% <0.00%> (-5.81%) ⬇️
unittests-3.6 58.79% <0.00%> (-5.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pylhe/__init__.py 67.46% <0.00%> (-6.42%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eduardo-rodrigues
Copy link
Member

@matthewfeickert, I tried to resolve the conflicts and believe this PR can now be closed given the fixes committed to master in the meantime. Then issue #76 can also be closed. Act as you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unweighted events produced from madgraph examples can't be read
3 participants