Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Require sphinx-rtd-theme compatible with Sphinx 7 #2271

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 10, 2023

Description

  • Update lower bound on sphinx-rtd-theme to v1.3.0rc1 to ensure compatibility with Sphinx v7+.
  • Update lower bound of Sphinx to v7.0.0 for consistency.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update lower bound on sphinx-rtd-theme to v1.3.0rc1 to ensure
  compatibility with Sphinx v7+.
   - c.f. https://github.com/readthedocs/sphinx_rtd_theme/issues/1463
   - As soon as sphinx-rtd-theme v1.3.0 is released on PyPI the lower
     bound should be updated to reflect this stable release. The release
     candidate is being used to unbreak CI.
* Update lower bound of Sphinx to v7.0.0 for consistency.

* Update lower bound on sphinx-rtd-theme to v1.3.0rc1 to ensure
  compatability with Sphinx v7+.
   - c.f. https://github.com/readthedocs/sphinx_rtd_theme/issues/ 1463
   - As soon as sphinx-rtd-theme v1.3.0 is released on PyPI the lower
     bound should be updated to reflect this stable release. The release
     candidate is being used to unbreak CI.
* Update lower bound of Sphinx to v7.0.0 for consistency.
@matthewfeickert matthewfeickert added docs Documentation related fix A bug fix need-to-backport tmp label until can be backported to patch release branch labels Aug 10, 2023
@matthewfeickert matthewfeickert self-assigned this Aug 10, 2023
@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 0da1313 into main Aug 10, 2023
18 checks passed
@matthewfeickert matthewfeickert deleted the docs/use-rc-of-sphinx-rtd-theme branch August 10, 2023 04:57
matthewfeickert added a commit that referenced this pull request Aug 16, 2023
* Update lower bound on sphinx-rtd-theme to v1.3.0rc1 to ensure
  compatibility with Sphinx v7+.
   - c.f. readthedocs/sphinx_rtd_theme#1463
   - As soon as sphinx-rtd-theme v1.3.0 is released on PyPI the lower
     bound should be updated to reflect this stable release. The release
     candidate is being used to unbreak CI.
* Update lower bound of Sphinx to v7.0.0 for consistency.
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Aug 16, 2023
matthewfeickert added a commit that referenced this pull request Aug 16, 2023
* Backport components of:
   - PR #2252
   - PR #2255
   - PR #2267
   - PR #2271
   - PR #2272
   - PR #2276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fix A bug fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant