fix: Replace deprecated np.product by np.prod

[alexander-held]

Description

Address the upcoming deprecation of numpy.product, which results in warnings as of numpy 1.25, by switching over to np.prod.

See https://numpy.org/devdocs/release/1.25.0-notes.html#deprecations:

np.product is deprecated. Use np.prod instead.
(gh-23314)

resolves #2241

Checklist Before Requesting Reviewer

• Tests are passing
• "WIP" removed from the title of the pull request
• Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

• Summarize commit messages into a comprehensive review of the PR

* Use np.prod API over np.product as np.product is deprecated
  as of NumPy v1.25.0.
   - c.f. https://numpy.org/devdocs/release/1.25.0-notes.html#deprecations

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (951912f) 98.30% compared to head (4a82a85) 98.30%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2242   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4533     4533           
  Branches      802      802           
=======================================
  Hits         4456     4456           
  Misses         45       45           
  Partials       32       32           

Flag	Coverage Δ
contrib	97.88% <100.00%> (ø)
doctest	61.08% <100.00%> (ø)
unittests-3.10	96.31% <100.00%> (ø)
unittests-3.11	96.31% <100.00%> (ø)
unittests-3.8	96.33% <100.00%> (ø)
unittests-3.9	96.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/pyhf/tensor/numpy_backend.py	98.61% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[matthewfeickert]

Thanks @alexander-held!

[matthewfeickert]

Oh before I merge this I should check to see if this requires us to bump the minimum version of scipy or not.

[matthewfeickert]

Oh before I merge this I should check to see if this requires us to bump the minimum version of scipy or not.

This is fine given

pyhf/pyproject.toml

Line 51 in 951912f

"scipy>=1.5.1", # requires numpy, which is required by pyhf and tensorflow

as scipy v1.5.1 requires numpy>=1.14.5 and the oldest version of NumPy to have wheels for Python 3.8 is numpy v1.17.3 which has both product and prod

$ python -c 'import numpy; print(numpy.__version__); print(numpy.product); print(numpy.prod)'
1.17.3
<function product at 0x7ff356be7280>
<function prod at 0x7ff356be2430>
$ 

👍

[matthewfeickert]

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.