Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(backport): Switch to using Hatchling as build backend #2148

Merged
merged 16 commits into from
Mar 31, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 30, 2023

Description

Backport PR #2095 (14127ae) to release/v0.7.x for v0.7.1 and ignore DeprecationWarning on release branches.

Also backport components of:

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport PR #2095 to the release/v0.7.x branch for easier comparisons.
* Also backport components of:
    - PR https://github.com/scikit-hep/pyhf/pull/2072
    - PR https://github.com/scikit-hep/pyhf/pull/2099
    - PR https://github.com/scikit-hep/pyhf/pull/2100
    - PR https://github.com/scikit-hep/pyhf/pull/2119
    - PR https://github.com/scikit-hep/pyhf/pull/2125
    - PR https://github.com/scikit-hep/pyhf/pull/2145
* In filterwarnings ignore all DeprecationWarning on patch release branches
  (e.g. release/v0.7.x).

@matthewfeickert matthewfeickert self-assigned this Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7ab10ed) 96.28% compared to head (7ab10ed) 96.28%.

❗ Current head 7ab10ed differs from pull request most recent head 8804b62. Consider uploading reports for the commit 8804b62 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release/v0.7.x    #2148   +/-   ##
===============================================
  Coverage           96.28%   96.28%           
===============================================
  Files                  69       69           
  Lines                4474     4474           
  Branches              608      608           
===============================================
  Hits                 4308     4308           
  Misses                127      127           
  Partials               39       39           
Flag Coverage Δ
unittests-3.7 96.28% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert added the backport Backport PRs from main to release branch label Mar 30, 2023
@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert marked this pull request as ready for review March 31, 2023 00:16
@matthewfeickert matthewfeickert merged commit 4c2cf30 into release/v0.7.x Mar 31, 2023
@matthewfeickert matthewfeickert deleted the chore/backport-transition-to-hatchling branch March 31, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport PRs from main to release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant