Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update JAX backend array_type to jaxlib.xla_extension.ArrayImpl #2134

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

matthewfeickert
Copy link
Member

Description

Update JAX backend array_type to jaxlib.xla_extension.ArrayImpl, which is a unified array type introduced in jaxlib v0.4.6.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update JAX backend array_type to jaxlib.xla_extension.ArrayImpl, which is a unified
  array type introduced in jaxlib v0.4.6.
   - c.f. https://github.com/google/jax/releases/tag/jaxlib-v0.4.6
   - c.f. https://github.com/google/jax/issues/14768

* Update JAX backend array_type to jaxlib.xla_extension.ArrayImpl, which is a unified
  array type introduced in jaxlib v0.4.6.
   - c.f. https://github.com/google/jax/releases/tag/jaxlib-v0.4.6
   - c.f. https://github.com/google/jax/issues/ 14768
@matthewfeickert matthewfeickert added docs Documentation related fix A bug fix labels Mar 13, 2023
@matthewfeickert matthewfeickert self-assigned this Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a4ec176) 98.30% compared to head (18b4a01) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2134   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4531     4531           
  Branches      645      645           
=======================================
  Hits         4454     4454           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.15% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/tensor/jax_backend.py 98.61% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fix A bug fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant