Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove 'lint' extra from setup.py #1943

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 12, 2022

Description

  • Remove the 'lint' extra. All linting should be done through pre-commit now and so there is no need to have a specific lint extra.
  • Remove the flake8 and black components of the lint workflow, as these are redundant to pre-commit.ci.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Remove the 'lint' extra. All linting should be done through pre-commit now
and so there is no need to have a specific lint extra.
* Remove the flake8 and black components of the lint workflow, as these are
redundant to pre-commit.ci.

* All linting should be done through pre-commit now and so there is
no need to have a specific lint extra.
@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions chore Other changes that don't modify src or test files labels Aug 12, 2022
@matthewfeickert matthewfeickert self-assigned this Aug 12, 2022
@matthewfeickert matthewfeickert requested a review from kratsg August 12, 2022 17:26
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1943 (81db3f2) into master (ad1dd86) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1943   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          69       69           
  Lines        4439     4439           
  Branches      748      748           
=======================================
  Hits         4362     4362           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 25.81% <ø> (ø)
doctest 61.02% <ø> (ø)
unittests-3.10 96.14% <ø> (ø)
unittests-3.7 96.13% <ø> (ø)
unittests-3.8 96.17% <ø> (ø)
unittests-3.9 96.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matthewfeickert matthewfeickert merged commit 6f8d87e into master Aug 12, 2022
@matthewfeickert matthewfeickert deleted the chore/remove-lint-extra branch August 12, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files CI CI systems, GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants