Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update lower bound on Sphinx to v5.1.1 #1926

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jul 27, 2022

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update lower bound of Sphinx to v5.1.1 to ensure consistent docs
builds. This is simpler than disallowing particular problematic versions
like Sphinx v5.1.0 given that the documentation can be viewed as a
deployment of an application and does not need to support as wide of a
version range as possible.
* Amends PR #1925.

* Update lower bound of Sphinx to v5.1.1 to ensure consistent docs
builds. This is simpler than disallowing particular problematic versions
like Sphinx v5.1.0 given that the documentation can be viewed as a
deployment of an application and does not need to support as wide of a
version range as possible.
* Amends PR 1925.
@matthewfeickert matthewfeickert added docs Documentation related build Changes that affect the build system or external dependencies labels Jul 27, 2022
@matthewfeickert matthewfeickert self-assigned this Jul 27, 2022
@matthewfeickert matthewfeickert marked this pull request as draft July 27, 2022 06:28
@matthewfeickert
Copy link
Member Author

Should wait for PR #1919 to go in first and then rebase.

@matthewfeickert matthewfeickert marked this pull request as ready for review August 8, 2022 20:49
@matthewfeickert
Copy link
Member Author

As this should be uncontroversial and getting this in should save time, I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit a4d5154 into master Aug 9, 2022
@matthewfeickert matthewfeickert deleted the buid/update-sphinx-lower-bound-to-5-1-1 branch August 9, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant