Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add 'name-tests-test' to pre-commit hooks #1877

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 6, 2022

Description

name-tests-test verifies that test files under tests/ conform to pytest naming conventions.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add the 'name-tests-test' pre-commit hooks which verifies that test files
under tests/ conform to pytest naming conventions.
   - Use the '--django' option to match the 'test*.py' naming convention.

* name-tests-test verifies that test files under tests/ conform to
pytest naming conventions.
@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Jun 6, 2022
@matthewfeickert matthewfeickert self-assigned this Jun 6, 2022
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #1877 (8006f47) into master (9135b41) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1877   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          68       68           
  Lines        4322     4322           
  Branches      726      726           
=======================================
  Hits         4243     4243           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.39% <ø> (ø)
doctest 60.73% <ø> (ø)
unittests-3.10 96.04% <ø> (ø)
unittests-3.7 96.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9135b41...8006f47. Read the comment docs.

@matthewfeickert
Copy link
Member Author

As other maintainers are on holiday, I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 42426e0 into master Jun 6, 2022
@matthewfeickert matthewfeickert deleted the ci/add-pytest-naming-check branch June 6, 2022 19:40
matthewfeickert added a commit that referenced this pull request Jun 22, 2022
* Update github.com/pre-commit/pre-commit-hooks: v4.2.0 → v4.3.0 to get `--pytest-test-first` option
for name-test-tests.
* Use `--pytest-test-first` option for name-test-tests for greater clarity of convention.
* Amends PR #1877.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant