Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add matplotlib nightly wheels to HEAD of dependencies testing #1835

Merged
merged 8 commits into from
Apr 1, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 1, 2022

Description

With the addition of matplotlib nightly wheels on the scipy-wheels-nightly Anaconda Cloud organization package index (c.f. matplotlib/matplotlib#22733), wheels that are either at, or very close to, matplotlib's HEAD on GitHub can now be tested.

As the only place that matplotlib is used in pyhf is in pyhf.contrib, only test the contrib module instead of all of pyhf.

Note for devs:

  • Need to use --extra-index-url as dependencies aren't on scipy-wheels-nightly package index.
  • Need to use --pre as dev releases will need priority over stable releases.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* With the addition of matplotlib nightly wheels on the
scipy-wheels-nightly Anaconda Cloud organization package index,
wheels that are either at, or very close to, matplotlib's HEAD
on GitHub can now be tested. As the only place that matplotlib
is used in pyhf is in pyhf.contrib, only test the contrib module
instead of all of pyhf.
   - c.f. https://anaconda.org/scipy-wheels-nightly

* With the addition of matplotlib nightly wheels on the
scipy-wheels-nightly Anaconda Cloud organization package index,
wheels that are either at, or very close to, matplotlib's HEAD
on GitHub can now be tested.
   - c.f. https://anaconda.org/scipy-wheels-nightly
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #1835 (b5917fe) into master (d8158cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1835   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          68       68           
  Lines        4315     4315           
  Branches      725      725           
=======================================
  Hits         4236     4236           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.44% <ø> (ø)
doctest 60.78% <ø> (ø)
unittests-3.10 96.03% <ø> (ø)
unittests-3.7 96.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8158cf...b5917fe. Read the comment docs.

@matthewfeickert matthewfeickert merged commit d41688e into master Apr 1, 2022
@matthewfeickert matthewfeickert deleted the test/add-matplotlib-to-head-of-dependencies branch April 1, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant