-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Remove wheel and attrs from build-system requires #1788
Conversation
@@ -1,6 +1,6 @@ | |||
[build-system] | |||
# Minimum requirements for the build system to execute. | |||
requires = ["wheel", "setuptools>=42.0.0", "attrs>=17.1", "setuptools_scm[toml]>=3.4"] | |||
requires = ["setuptools>=42.0.0", "setuptools_scm[toml]>=3.4"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henryiii In scikit-hep/boost-histogram#394 you bumped the setuptools_scm
lower bound to setuptools_scm[toml]>=4.1.2
but have it still as setuptools_scm[toml]>=3.4
in hist
. Is there a particular reason for the newer version in boost-histogram
that we should be updating the lower bounds for as well?
Codecov Report
@@ Coverage Diff @@
## master #1788 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 64 64
Lines 4270 4270
Branches 683 683
=======================================
Hits 4190 4190
Misses 46 46
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I'm going to merge this in and just make another PR later if Henry has advice on changing |
I think I made an error when I made the commit message. This is covered (I think) by |
Description
Resolves #1787
As noted by @henryiii in scikit-hep/pylhe#111, neither
wheel
orattrs
are needed.get_requires_for_build_sdist
and so already covered.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: