Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove wheel and attrs from build-system requires #1788

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Feb 24, 2022

Description

Resolves #1787

As noted by @henryiii in scikit-hep/pylhe#111, neither wheel or attrs are needed.

  • Remove wheel from build-system requires as it is declared by PEP 517's get_requires_for_build_sdist and so already covered.
  • Remove attrs as not required at build time.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Remove wheel from build-system requires as it is declared by
PEP 517's get_requires_for_build_sdist and so already covered.
   - c.f. https://www.python.org/dev/peps/pep-0517/
* Remove attrs as not required at build time.

@matthewfeickert matthewfeickert added the build Changes that affect the build system or external dependencies label Feb 24, 2022
@matthewfeickert matthewfeickert self-assigned this Feb 24, 2022
@@ -1,6 +1,6 @@
[build-system]
# Minimum requirements for the build system to execute.
requires = ["wheel", "setuptools>=42.0.0", "attrs>=17.1", "setuptools_scm[toml]>=3.4"]
requires = ["setuptools>=42.0.0", "setuptools_scm[toml]>=3.4"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henryiii In scikit-hep/boost-histogram#394 you bumped the setuptools_scm lower bound to setuptools_scm[toml]>=4.1.2 but have it still as setuptools_scm[toml]>=3.4 in hist. Is there a particular reason for the newer version in boost-histogram that we should be updating the lower bounds for as well?

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #1788 (8feb160) into master (7428bed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1788   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          64       64           
  Lines        4270     4270           
  Branches      683      683           
=======================================
  Hits         4190     4190           
  Misses         46       46           
  Partials       34       34           
Flag Coverage Δ
contrib 26.25% <ø> (ø)
doctest 60.58% <ø> (ø)
unittests 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7428bed...8feb160. Read the comment docs.

@matthewfeickert
Copy link
Member Author

I'm going to merge this in and just make another PR later if Henry has advice on changing setuptools_scm[toml] lower bounds.

@matthewfeickert matthewfeickert merged commit 2533bd9 into master Feb 24, 2022
@matthewfeickert matthewfeickert deleted the build/remove-wheel-and-atts branch February 24, 2022 17:39
@matthewfeickert
Copy link
Member Author

I think I made an error when I made the commit message. This is covered (I think) by get_requires_for_build_wheel not get_requires_for_build_sdist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove wheel and attrs from build-system requires
1 participant