ci: Add macos-latest to dependency release candidates testing #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As seen in Issue 1759, testing pre-releases of software only on Linux distributions is not enough to catch bugs before they hit in public releases. To guard against this in the future, add macos-latest to tests for pre-releases on PyPI.
matthewfeickert
changed the title
matthewfeickert
changed the title
|
Given that Issue #1759 hasn't been fixed yet, the CI here is going to fail, but I'll let the reviewer decide if they want to hold off on merging this until things are patched or not. |
Codecov Report
@@ Coverage Diff @@
## master #1760 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 64 64
Lines 4270 4270
Branches 683 683
=======================================
Hits 4190 4190
Misses 46 46
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As seen in Issue #1759, testing release candidates of software only on Linux distributions is not enough to catch bugs before they hit in public releases. To guard against this in the future, add
macos-latestto tests for release candidates on PyPI.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: