-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use constraints.txt for lower bound testing #1713
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1713 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 64 64
Lines 4269 4269
Branches 682 682
=======================================
Hits 4189 4189
Misses 46 46
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
If I diff the output of $ diff --color -u /tmp/lower-bound-requirements-output.txt /tmp/constraints-output.txt
--- /tmp/lower-bound-requirements-output.txt 2021-11-29 20:44:15.692252460 -0600
+++ /tmp/constraints-output.txt 2021-11-29 20:44:41.536190380 -0600
@@ -1,11 +1,12 @@
absl-py 1.0.0
ansiwrap 0.8.4
+appdirs 1.4.4
argcomplete 1.12.3
argon2-cffi 21.1.0
astunparse 1.6.3
attrs 21.2.0
backcall 0.2.0
-black 21.11b1
+black 20.8b0
bleach 4.1.0
cachetools 4.2.4
certifi 2021.10.8
@@ -80,7 +81,6 @@
pickleshare 0.7.5
Pillow 8.4.0
pip 21.3.1
-platformdirs 2.4.0
pluggy 1.0.0
prometheus-client 0.12.0
prompt-toolkit 3.0.23 which seems acceptable as none of those are specified in either files. So I'll merge this now that there is 1 approval. |
Description
As suggested by @henryiii on Twitter, rename the
lower-bound-requirements.txt
toconstraints.txt
and use it as apip
constraints file instead of as arequirements.txt
.and from the
pip
docs on constraints files:As also suggested by @henryiii in Issue #1685, move the
constraints.txt
under thetests
directory to reduce clutter in the top level directory.As constraints files work like requirements files they are still able to follow
--find-links
URLs and so can download oldjaxlib
releases fromhttps://storage.googleapis.com/jax-releases/jax_releases.html
. 👍Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: