Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use https protocol as unauthenticated git protocol is no longer supported #1680

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 2, 2021

Description

Use of the unauthenticated git protocol (git://) is no longer supported on GitHub (c.f. the 2021-09-01 GitHub Security blog Improving Git protocol security on GitHub). As a result, the current HEAD of dependencies workflow fails with the following error.

Collecting git+git://github.com/scikit-hep/uproot4.git
  Cloning git://github.com/scikit-hep/uproot4.git to /tmp/pip-req-build-faju_mnt
  Running command git clone --filter=blob:none -q git://github.com/scikit-hep/uproot4.git /tmp/pip-req-build-faju_mnt
  fatal: remote error:
    The unauthenticated git protocol on port 9418 is no longer supported.
  Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
WARNING: Discarding git+git://github.com/scikit-hep/uproot4.git. Command errored out with exit status 128: git clone --filter=blob:none -q git://github.com/scikit-hep/uproot4.git /tmp/pip-req-build-faju_mnt Check the logs for full command output.
ERROR: Command errored out with exit status 128: git clone --filter=blob:none -q git://github.com/scikit-hep/uproot4.git /tmp/pip-req-build-faju_mnt Check the logs for full command output.

To avoid this, use the https:// for cloning a Git repo.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Use the https protocol to clone Git repositories over the
unauthenticated git protocol (git://) as it is no longer
supported on GitHub as of 2021-11-02.
   - c.f. https://github.blog/2021-09-01-improving-git-protocol-security-github/

@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions fix A bug fix labels Nov 2, 2021
@matthewfeickert matthewfeickert self-assigned this Nov 2, 2021
@matthewfeickert matthewfeickert changed the title fix: Use https protocol as unauthenticated git protocol is no longer supported on GitHub fix: Use https protocol as unauthenticated git protocol is no longer supported Nov 2, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1680 (b27dcea) into master (377b85d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1680   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files          64       64           
  Lines        4213     4213           
  Branches      585      585           
=======================================
  Hits         4131     4131           
  Misses         49       49           
  Partials       33       33           
Flag Coverage Δ
contrib 25.30% <ø> (ø)
doctest 61.04% <ø> (ø)
unittests 96.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 377b85d...b27dcea. Read the comment docs.

@matthewfeickert
Copy link
Member Author

matthewfeickert commented Nov 2, 2021

I'm going to merge this without getting additional sign off as it is a change in Git cloning protocol that we have no choice but to adopt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant