refactor: Use jax.numpy for JAX backend tensorlib.tolist #1138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1137
In more recent releases of JAX the
jax.numpy
module is more filled out and it now supportsjax.numpy.tolist
, which was the only thing NumPy was used for previously.NumPy must still be kept as JAX relies on
numpy
itself to convert from JAX DeviceArray to NumPypyhf/src/pyhf/tensor/jax_backend.py
Lines 568 to 593 in 2b2b281
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: