docs: 1000! #1000
Merged
docs: 1000! #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratsg
approved these changes
Jul 27, 2020
matthewfeickert
requested changes
Jul 27, 2020
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Codecov Report
@@ Coverage Diff @@
## master #1000 +/- ##
=======================================
Coverage 96.65% 96.65%
=======================================
Files 59 59
Lines 3284 3284
Branches 455 455
=======================================
Hits 3174 3174
Misses 69 69
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
99PI reference and also Matthew is bad at remembering syntax
matthewfeickert
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
LGTM now that I fixed my syntax error. Thanks for the commemorative PR @lukasheinrich, and thanks to you and @kratsg for making this a thing that we do. :)
matthewfeickert
requested changes
Jul 28, 2020
matthewfeickert
approved these changes
Jul 28, 2020
matthewfeickert
force-pushed
the
milestones/1k_github_items
branch
from
41ffff4 to
c059ecc
Compare
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is our #1000's GitHub item!
ReadTheDocs build: https://pyhf.readthedocs.io/en/milestones-1k_github_items/#milestones
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: