Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure that __copy__ and __deepcopy__ are enabled. #1695

Merged
merged 10 commits into from
Sep 14, 2022
Merged

fix: ensure that __copy__ and __deepcopy__ are enabled. #1695

merged 10 commits into from
Sep 14, 2022

Commits on Sep 13, 2022

  1. fix: ensure that and are enabled.

    @jpivarski
    jpivarski committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    1a174e2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into jpivarski/ensure-copy-deepcopy-are-enabled

    @jpivarski
    jpivarski committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    5f39be3 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Implemented all the (missing) copy/deepcopy methods.

    @jpivarski
    jpivarski committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    4cc7ae9 View commit details
    Browse the repository at this point in the history

  2. refactor: use private parameters where possible

    @agoose77
    agoose77 committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    d02d927 View commit details
    Browse the repository at this point in the history

  3. fix: use _length not _zeros_length in RegularArray.copy()` 

    NB. I did think about introducing a `zeros_length` attribute, but I am concerned that we would need to take a great deal of care in handling this parameter for no good cause. Instead, we should make it such that the `length` parameter is the only externally visible one.
    @agoose77
    agoose77 committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    0a7bf2e View commit details
    Browse the repository at this point in the history

  4. refactor: replace Content.__deepcopy__ with abstract method 

    This will ensure we *have* to implement this routine. Although we could use a dynamic deepcopy, it opens us up to more bugs (explicit vs implicit) and hides some of the copying logic.
    @agoose77
    agoose77 committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    dd8307e View commit details
    Browse the repository at this point in the history

  5. refactor: remove unneeded optional in __deepcopy__ signature.

    @agoose77
    agoose77 committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    a3e9791 View commit details
    Browse the repository at this point in the history

  6. fix: use copy.deepcopy to dispatch copying 

    This avoids handling deep copying in two places
    @agoose77
    agoose77 committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    802c2e9 View commit details
    Browse the repository at this point in the history

  7. fix: deepcopy(behavior) in Array/Record.__deepcopy__

    @agoose77
    agoose77 committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    7b63af4 View commit details
    Browse the repository at this point in the history

  8. fix: use copy.deepcopy in tests

    @agoose77
    agoose77 committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    894aa3f View commit details
    Browse the repository at this point in the history