feat: prevent reducers like ak.sum on records (v2) #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
jpivarski
requested changes
Aug 24, 2022
There was a problem hiding this comment.
Great! I just have one requested change. You've added a behavior-lookup, and there's a common form for those in helper functions in _util. See below.
With that behavior-lookup refactored out to _util.py, this will be ready. Re-request me to review it and I'll do a quick check, then merge.
Thanks!
ioanaif
changed the title
jpivarski
reviewed
Aug 25, 2022
jpivarski
approved these changes
Aug 25, 2022
utility
ioanaif
changed the title
Saransh-cpp
pushed a commit
to Saransh-cpp/awkward
that referenced
this pull request
Aug 29, 2022
* policy: Prevent reducers like ak.sum on records (v2) * Pass behavior on the rest of the reducers * Made a util function for checking if a reducer function is overloaded for records * Switch using .split with .name * Add 'highlevel_function() utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1375:
If we have records whose fields represent non-Cartesian data, they should not be naively added (or otherwise "reduced")
In V2, this will now throw a TypeError
Error details: no ak.sum overloads for custom types: rho, phi