Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure cpp headers #1524

Merged
merged 1 commit into from
Jul 1, 2022
Merged

restructure cpp headers #1524

merged 1 commit into from
Jul 1, 2022

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Jul 1, 2022

extract common code to a separate header file

@ianna
Copy link
Collaborator Author

ianna commented Jul 1, 2022

@ManasviGoyal - FYI. When this is merged you can update your PR with:

#include "utils.h"

and remove the duplicated code from LayoutBuilder.h. Thanks!

@ManasviGoyal
Copy link
Collaborator

ManasviGoyal commented Jul 1, 2022

@ManasviGoyal - FYI. When this is merged you can update your PR with:

#include "utils.h"

and remove the duplicated code from LayoutBuilder.h. Thanks!

Sure. Thanks!

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1524 (8105b66) into main (0c6ae03) will decrease coverage by 2.74%.
The diff coverage is 76.88%.

Impacted Files Coverage Δ
...awkward/_v2/_connect/rdataframe/from_rdataframe.py 0.00% <0.00%> (ø)
...c/awkward/_v2/_connect/rdataframe/to_rdataframe.py 0.00% <0.00%> (ø)
src/awkward/_v2/config.py 0.00% <0.00%> (ø)
src/awkward/_v2/types/_awkward_datashape_parser.py 47.66% <ø> (ø)
src/awkward/_v2/_connect/cling.py 25.99% <9.09%> (-0.35%) ⬇️
src/awkward/_v2/types/recordtype.py 87.06% <91.66%> (+0.83%) ⬆️
src/awkward/_v2/types/type.py 96.46% <96.10%> (-1.27%) ⬇️
src/awkward/_v2/_lookup.py 97.51% <100.00%> (+0.01%) ⬆️
src/awkward/_v2/types/__init__.py 100.00% <100.00%> (ø)
src/awkward/_v2/types/regulartype.py 90.47% <0.00%> (+4.76%) ⬆️

@ianna ianna requested a review from jpivarski July 1, 2022 11:38
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving generic things like this out to a new utils.h is a good idea.

@jpivarski jpivarski merged commit 17fd7c0 into main Jul 1, 2022
@jpivarski jpivarski deleted the ianna/cpp-headers-restructure branch July 1, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants