Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename low-level methods to match high-level function names. #1468

Merged
merged 4 commits into from
May 13, 2022

Conversation

jpivarski
Copy link
Member

@jpivarski jpivarski commented May 13, 2022

There were fewer of these than I thought there was going to be.

  • localindex → local_index
  • validityerror → validity_error
  • rpad → pad_none
  • withparameter → with_parameter

I changed mid-level names (i.e. on the layouts) because that's a public interface for downstream developers. I didn't change any kernel function names because those are totally internal and can be changed at any time. Also, those wouldn't be across-the-board changes that affect mergeability. Also, also, the kernel names aren't very good as they are, but they're defined in terms of their function (the Python snippets in kernel-signatures.yml), rather than a meaningful name.

@codecov
Copy link

codecov bot commented May 13, 2022

@jpivarski jpivarski marked this pull request as ready for review May 13, 2022 19:03
@jpivarski jpivarski enabled auto-merge (squash) May 13, 2022 19:04
@jpivarski
Copy link
Member Author

There were fewer of those than I thought there was going to be.

@jpivarski jpivarski merged commit 9d417d5 into main May 13, 2022
@jpivarski jpivarski deleted the jpivarski/make-lowlevel-names-match-highlevel-names branch May 13, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant