Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled string/categorical behavior #1421

Merged
merged 6 commits into from
Apr 19, 2022
Merged

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Apr 14, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1421 (0592a1c) into main (edfce38) will decrease coverage by 0.48%.
The diff coverage is 42.89%.

Impacted Files Coverage Δ
src/awkward/_v2/_connect/cuda/__init__.py 0.00% <0.00%> (ø)
src/awkward/_v2/_connect/jax/__init__.py 0.00% <0.00%> (ø)
src/awkward/_v2/contents/content.py 81.91% <0.00%> (-0.13%) ⬇️
src/awkward/_v2/operations/convert/ak_from_cupy.py 50.00% <0.00%> (+23.33%) ⬆️
src/awkward/_v2/operations/convert/ak_from_iter.py 93.75% <ø> (ø)
src/awkward/_v2/operations/convert/ak_from_jax.py 50.00% <0.00%> (-25.00%) ⬇️
src/awkward/_v2/operations/convert/ak_to_cupy.py 33.33% <0.00%> (+23.95%) ⬆️
src/awkward/_v2/operations/convert/ak_to_jax.py 33.33% <0.00%> (-41.67%) ⬇️
src/awkward/_v2/operations/describe/ak_backend.py 10.00% <0.00%> (-2.50%) ⬇️
...wkward/_v2/operations/structure/ak_argcartesian.py 78.94% <ø> (ø)
... and 31 more

@ioanaif ioanaif marked this pull request as ready for review April 19, 2022 15:55
@ioanaif ioanaif requested a review from jpivarski April 19, 2022 15:56
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This should merge well with #1427. I made some of the same changes there (without all of the other tests).

As we agreed on Slack, this doesn't mean that categorical is done, but you have some questions for @ianna about is_unique.

tests/v2/test_0028-add-dressed-types.py Outdated Show resolved Hide resolved
@jpivarski jpivarski enabled auto-merge (squash) April 19, 2022 16:05
@jpivarski jpivarski merged commit 68a0e9e into main Apr 19, 2022
@jpivarski jpivarski deleted the ioanaif/v2_string_behaviors branch April 19, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants