-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed bytemask() in favour of mask_as_bool() #1410
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I did a grep
and found one more case, and I think I know why that one was there. (See below.)
This is ready to merge!
mask0 = module.asarray(array.bytemask()).view(np.bool_) | ||
mask0 = array.mask_as_bool(valid_when=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This last case illustrates why we want to avoid having both bytemask
and mask_as_bool
. You didn't see it, @ioanaif, because it was added by @swishdiff, and @swishdiff didn't know that bytemask
was being removed.
No description provided.