split up functions #1397
split up functions #1397
Conversation
|
It's a good factorization. Be aware that your git submodules are out of date, and that's why they're being counted as diffs in this PR. @agoose77 also suggested turning the ErrorContext manager into a decorator, which is something we should do across all the functions, not in this PR. |
Remind me how to make this go away?
Agreed - it's here because it helped me reason about what the code was doing. |
I don't remember the git commands, so I always just clone a new repo. I just looked it up: you
|
Codecov Report
|
|
OK, @jpivarski , this actually runs. It still does not handle _metadata or directory partitioning, but there should be enough here for dask-awkward to use. (cc @douglasdavis , since we talked about this) |
|
I'll be looking it over more carefully soon. In the meantime, I just want to make sure that this PR wouldn't change the pybind11 version. |
There was a problem hiding this comment.
This looks done to me! @martindurant, is there anything else you want to do in this PR? Otherwise, I'll be merging it.
* Fixed a bug in RecordArray.to_arrow and consequences for from_arrow. * conservative_optiontype -> generate_bitmasks because it no longer controls whether an array is option-type. * More concise option[string/bytes/char/byte] type string. * Merged with main (and #1397).
Quite aside from the options we talked about for various ways to handle file layout, this kind of splitting up of functionality is very helpful for reusing the code in dask. I haven't checked whether this actually works yet, I probably mistyped along the way, but I wanted to show the idea.