If this test passes, #1283 is fixed. #1388

jpivarski · 2022-03-29T22:11:57Z

No description provided.

for more information, see https://pre-commit.ci

jpivarski · 2022-03-29T22:41:46Z

Right: it fails because #1274 fixes v2 without fixing v1. I just wanted to confirm that this is where it stands for now.

codecov · 2022-03-29T22:42:24Z

Codecov Report

Merging #1388 (1d47b9c) into main (b2fd2be) will decrease coverage by 0.89%.
The diff coverage is 55.42%.

Impacted Files	Coverage Δ
src/awkward/_v2/_connect/cling.py	`0.00% <0.00%> (ø)`
src/awkward/_v2/_connect/cuda/__init__.py	`0.00% <0.00%> (ø)`
src/awkward/_v2/_lookup.py	`97.50% <0.00%> (ø)`
src/awkward/_v2/_prettyprint.py	`66.09% <0.00%> (+2.29%)`	⬆️
src/awkward/_v2/identifier.py	`55.69% <0.00%> (ø)`
src/awkward/_v2/operations/convert/ak_from_jax.py	`75.00% <0.00%> (ø)`
src/awkward/_v2/operations/convert/ak_to_jax.py	`75.00% <0.00%> (ø)`
src/awkward/_v2/operations/io/ak_from_parquet.py	`75.00% <0.00%> (ø)`
src/awkward/_v2/operations/io/ak_to_parquet.py	`75.00% <0.00%> (ø)`
src/awkward/_v2/operations/structure/ak_firsts.py	`75.00% <0.00%> (ø)`
... and 156 more

jpivarski · 2022-04-26T18:57:46Z

This PR is included within #1389 and doesn't need to stay open. #1389 takes over its role as the one to close #1283.

If this test passes, #1283 is fixed.

a187333

jpivarski linked an issue Mar 29, 2022 that may be closed by this pull request

ak.sum segfault: backport v2 solution into v1 #1283

Closed

jpivarski enabled auto-merge (squash) March 29, 2022 22:12

[pre-commit.ci] auto fixes from pre-commit.com hooks

1d47b9c

for more information, see https://pre-commit.ci

jpivarski removed a link to an issue Apr 26, 2022

ak.sum segfault: backport v2 solution into v1 #1283

Closed

jpivarski closed this Apr 26, 2022

auto-merge was automatically disabled April 26, 2022 18:57
Pull request was closed

jpivarski deleted the jpivarski/macos-segfault-in-reducer branch September 23, 2022 00:49