C++ refactoring: ak.run_lengths #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
|
jpivarski
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Also looks good. I see that you've enabled a string behavior (vectorized equality). That should allow tests like
assert ak.all(ak.Array(["one", "two", "three"]) == ak.Array(["one", "two", "three"]))
assert ak.any(ak.Array(["one", "two", "three"]) != ak.Array(["one", "two", "3"]))
assert not ak.all(ak.Array(["one", "two", "three"]) != ak.Array(["one", "two", "3"]))(Without the equality behavior, it would try to compare "t" with "3" and complain about the different number of characters; with the behavior, it would compare "three" with "3" as whole units.)
The run_lengths implementation also looks good.
Comment on lines
254
to
+257
| # behavior[ak.nplike.numpy.equal, "bytestring", "bytestring"] = _string_equal | ||
| # behavior[ak.nplike.numpy.equal, "string", "string"] = _string_equal | ||
| # behavior[ak.nplike.numpy.not_equal, "bytestring", "bytestring"] = _string_notequal | ||
| # behavior[ak.nplike.numpy.not_equal, "string", "string"] = _string_notequal | ||
| behavior[ak.nplike.numpy.not_equal, "string", "string"] = _string_notequal |
There was a problem hiding this comment.
With _string_equal implemented, it should be possible to enable all four of these. I guess only one was needed for the test. (Enabling these string and categorical behaviors is one of the cards.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.