Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Straighten out error handling via a thread-local (but otherwise global) context #1327

Merged
merged 16 commits into from
Mar 3, 2022
Merged

Straighten out error handling via a thread-local (but otherwise global) context #1327

merged 16 commits into from
Mar 3, 2022

Commits on Feb 28, 2022

  1. Introduce an ErrorContext manager.

    @jpivarski
    jpivarski committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    d652017 View commit details
    Browse the repository at this point in the history

  2. Content._carry won't be needing its 3rd argument anymore.

    @jpivarski
    jpivarski committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    a309d44 View commit details
    Browse the repository at this point in the history

  3. Replace NestedIndexError with nested_indexerror.

    @jpivarski
    jpivarski committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    606650f View commit details
    Browse the repository at this point in the history

  4. Remove NestedIndexError entirely. Using ErrorContext now.

    @jpivarski
    jpivarski committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    7d415a5 View commit details
    Browse the repository at this point in the history

  5. Move error-handling to ak._v2._util.

    @jpivarski
    jpivarski committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    17fd5f5 View commit details
    Browse the repository at this point in the history

  6. Every exception should pass through ak._v2._util.error.

    @jpivarski
    jpivarski committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    4e88a89 View commit details
    Browse the repository at this point in the history

  7. ak._v2._util.error can now check for contexts.

    @jpivarski
    jpivarski committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    af36012 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Defined error format for operations.

    @jpivarski
    jpivarski committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    76b5f67 View commit details
    Browse the repository at this point in the history

  2. Now every operation sets the OperationErrorContext.

    @jpivarski
    jpivarski committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    656ffbf View commit details
    Browse the repository at this point in the history

  3. Now they do (I missed a big batch last time).

    @jpivarski
    jpivarski committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    c9becd2 View commit details
    Browse the repository at this point in the history

  4. Avoid reentering the OperationErrorContext.

    @jpivarski
    jpivarski committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    184fcaf View commit details
    Browse the repository at this point in the history

  5. Make reducers non-reenterant, too.

    @jpivarski
    jpivarski committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    813b462 View commit details
    Browse the repository at this point in the history

  6. Merged with main.

    @jpivarski
    jpivarski committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    7ec12db View commit details
    Browse the repository at this point in the history

  7. Merged with main.

    @jpivarski
    jpivarski committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    7d6bbbf View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2022

  1. chore: add a custom flake8 check

    @henryiii
    henryiii committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    94ce51c View commit details
    Browse the repository at this point in the history

  2. Fix that one NotImplementedError.

    @jpivarski
    jpivarski committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    f962184 View commit details
    Browse the repository at this point in the history