Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support multiplexed path #896

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix: support multiplexed path #896

merged 3 commits into from
Sep 10, 2024

Conversation

henryiii
Copy link
Collaborator

Pulling out this fix from #880 for inclusion in a patch release.

Co-authored-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.86%. Comparing base (a3df152) to head (a5fdfa7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/scikit_build_core/builder/builder.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   83.90%   83.86%   -0.05%     
==========================================
  Files          74       74              
  Lines        4387     4393       +6     
==========================================
+ Hits         3681     3684       +3     
- Misses        706      709       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii merged commit 37daf61 into main Sep 10, 2024
61 checks passed
@henryiii henryiii deleted the henryiii/fix/multiplexedpath branch September 10, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants