Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support windows free-threading #759

Merged
merged 1 commit into from
May 31, 2024
Merged

fix: support windows free-threading #759

merged 1 commit into from
May 31, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented May 31, 2024

Fixing the logic for finding a library to link to. Python fills the LIBRARY slot with .dll for some reason. CMake was fixing this by finding the .lib anyway, but now we feed it the right library to begin with, which fixes free-threading builds. Tests are currently just downstream in scikit-build-sample-projects until there's an easier way to get a free-threaded build in GHA, especially for Windows.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii marked this pull request as ready for review May 31, 2024 20:51
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.95%. Comparing base (33d61f1) to head (37fe3b5).
Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
src/scikit_build_core/builder/sysconfig.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
- Coverage   81.98%   81.95%   -0.04%     
==========================================
  Files          68       68              
  Lines        3903     3913      +10     
==========================================
+ Hits         3200     3207       +7     
- Misses        703      706       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii added the bug Something isn't working label May 31, 2024
@henryiii henryiii enabled auto-merge (squash) May 31, 2024 21:03
@henryiii henryiii disabled auto-merge May 31, 2024 21:04
@henryiii henryiii merged commit 22dbcc0 into main May 31, 2024
51 checks passed
@henryiii henryiii deleted the henryiii/ci/fixwint branch May 31, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant