Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix example of configuration overrides in configuration.md #739

Merged
merged 1 commit into from
May 11, 2024

Conversation

wu-vincent
Copy link
Contributor

@wu-vincent wu-vincent commented May 9, 2024

The example provided is not working anymore and will yield errors. This pull request will fix the issue.

@wu-vincent wu-vincent changed the title fix: example of configuration overrides in configuration.md docs: fix example of configuration overrides in configuration.md May 9, 2024
Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.97%. Comparing base (2994db5) to head (7406a9a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
+ Coverage   81.40%   81.97%   +0.56%     
==========================================
  Files          68       68              
  Lines        3888     3888              
==========================================
+ Hits         3165     3187      +22     
+ Misses        723      701      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit ae6c063 into scikit-build:main May 11, 2024
44 of 46 checks passed
@wu-vincent wu-vincent deleted the patch-1 branch May 11, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants