Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make run command logged at info #639

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

LecrisUT
Copy link
Collaborator

From #629

Maybe this level should be split for more granularity like:

  • status for messages that should always be outputted like when it enters a configure/build stage, etc.
  • info for tracing basic execution, like in this case what commands are run

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdeb832) 86.23% compared to head (1259d18) 86.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #639   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files          63       63           
  Lines        3233     3233           
=======================================
  Hits         2788     2788           
  Misses        445      445           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT
Copy link
Collaborator Author

Nvm the rawhide failure. F40 just branched today so it might take some time to recover

@henryiii henryiii merged commit fe5841d into scikit-build:main Feb 14, 2024
45 of 49 checks passed
@LecrisUT LecrisUT deleted the fix/logger-level branch March 28, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants