Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always build from sources #61

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Jul 18, 2021

This helps not to depend on upstream builds given we were already building almost all from sources with the exception of macOS build and Windows x86_64 build.

see also #41

@mayeut mayeut force-pushed the always-build-from-sources branch from d5754dd to 89fccb3 Compare July 18, 2021 13:53
@mayeut mayeut marked this pull request as ready for review July 18, 2021 13:53
@mayeut mayeut marked this pull request as draft July 18, 2021 15:16
@mayeut
Copy link
Contributor Author

mayeut commented Jul 18, 2021

Something weird happened in one build of #62
I suspect it could be related to scikit-build/scikit-build#526
If the build with windows-2016 is ok on #62, I will update this one before putting it out-of-draft cause I suspect it's using mingw gcc right now...

@mayeut mayeut force-pushed the always-build-from-sources branch from 89fccb3 to 5f8800e Compare July 18, 2021 15:28
@mayeut mayeut marked this pull request as ready for review July 18, 2021 16:12
@mayeut mayeut force-pushed the always-build-from-sources branch from 5f8800e to ab585c8 Compare July 19, 2021 23:17
@mayeut mayeut force-pushed the always-build-from-sources branch from ab585c8 to 99f1c24 Compare July 24, 2021 10:09
@mayeut mayeut requested review from jcfr and henryiii July 24, 2021 10:36
@henryiii henryiii merged commit da9c0ea into scikit-build:master Jul 27, 2021
@mayeut mayeut deleted the always-build-from-sources branch July 27, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants