-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ninja to 1.9.0.g5b44b.kitware.dyndep-1.jobserver-1 #17
Conversation
Todo (Jc):
|
Just as I sat down to rebase this change I saw that you did @jcfr. Thanks! Not entirely sure what the issue that's coming up in CI builds are related to though. I can see that the name assertion fails, but unless I'm mistaken the filename with |
Thanks @kjerstadius for looking into this. I am having a look and should get everything sorted out by the end of the day (EST time) |
The specific branch is not needed anymore, compat with older Visual Studio was fixed in ninja-build/ninja@0db30f2 |
Few jobs failed because of issue with upload to codecov.io. I manually retriggered the failed job. |
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 86.95% 86.95%
=======================================
Files 1 1
Lines 23 23
Branches 3 3
=======================================
Hits 20 20
Partials 3 3 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a minor tweaks in the distribution test. 👍
Not much to say really. Just update the ninja binaries to the latest version.