Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ninja to 1.9.0.g5b44b.kitware.dyndep-1.jobserver-1 #17

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

kjerstadius
Copy link
Contributor

Not much to say really. Just update the ninja binaries to the latest version.

@thewtex thewtex requested a review from jcfr February 24, 2019 02:32
@jcfr
Copy link
Contributor

jcfr commented Feb 25, 2019

Todo (Jc):

@kjerstadius
Copy link
Contributor Author

kjerstadius commented Feb 25, 2019

Just as I sat down to rebase this change I saw that you did @jcfr. Thanks! Not entirely sure what the issue that's coming up in CI builds are related to though. I can see that the name assertion fails, but unless I'm mistaken the filename with .git. rather than .g5b44b. in the name seems to come from the built archive. Did something go wrong with the binary creation "upstream"? Or is it somehow related to your todo? I did notice the removal of those lines you mentioned related to MSVC. I didn't know what to make of it really, so I just made the change and hoped that it would work :) In any case, let me know if you need me to do anything.

@jcfr
Copy link
Contributor

jcfr commented Feb 25, 2019

Thanks @kjerstadius for looking into this.

I am having a look and should get everything sorted out by the end of the day (EST time)

@jcfr
Copy link
Contributor

jcfr commented Feb 26, 2019

The specific branch is not needed anymore, compat with older Visual Studio was fixed in ninja-build/ninja@0db30f2

@jcfr
Copy link
Contributor

jcfr commented Feb 26, 2019

Few jobs failed because of issue with upload to codecov.io. I manually retriggered the failed job.

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files           1        1           
  Lines          23       23           
  Branches        3        3           
=======================================
  Hits           20       20           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f5a68...005feb1. Read the comment docs.

@jcfr jcfr merged commit e1282ec into scikit-build:master Feb 26, 2019
Copy link
Contributor

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a minor tweaks in the distribution test. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants