Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): GHA updates #305

Merged
merged 5 commits into from
Nov 1, 2022
Merged

chore(deps): GHA updates #305

merged 5 commits into from
Nov 1, 2022

Conversation

henryiii
Copy link
Contributor

We are getting warnings about things like node 12 being removed soon.

@henryiii
Copy link
Contributor Author

I'm going to add a "pass" check, which will make this easier in the future. Currently we have to change the required checks every time a check gets renamed.

@mayeut
Copy link
Contributor

mayeut commented Oct 31, 2022

I'm going to add a "pass" check, which will make this easier in the future. Currently we have to change the required checks every time a check gets renamed.

Can't we just require check_dist to pass, it should be enough ? It already needs all the jobs needed by the new pass check.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@henryiii henryiii merged commit 349a2ae into master Nov 1, 2022
@henryiii henryiii deleted the henryiii-patch-1 branch November 1, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants