Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing macOS ci #131

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Try fixing macOS ci #131

merged 1 commit into from
Apr 9, 2021

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Apr 7, 2021

No description provided.

@jcfr
Copy link
Contributor

jcfr commented Apr 7, 2021

Thanks @mayeut 🙏 🎉

We are getting close 💯

This commit fixes macOS continuous integration applying the following changes:
* remove the use of brew/pyenv
* install official python distribution
  - update from 2.7.15 to 2.7.18
  - udpate from 3.7.8 to 3.7.9
* install certifi using script from cibuildwheel
* create a virtual environment in  ~/.pyenv/versions/${PYTHON_VERSION} sub-directory

For reference, this commit also reverts the following commits:
* 28b0d4b (ci: Update travis to fix "libintl" loading error)
* 0be7aea (ci: Fix macOS build using pip2 instead of pip)
* 6ec58d7 (ci: Tweak cache and before_cache steps)

See scikit-build#129

Co-authored-by: Jean-Christophe Fillion-Robin <jcfr@kitware.com>
@jcfr jcfr marked this pull request as ready for review April 9, 2021 05:40
@jcfr jcfr merged commit 080d24e into scikit-build:master Apr 9, 2021
@mayeut mayeut deleted the fix-macos-ci branch April 9, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants