Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate wheels without python ABI #71

Closed
jcfr opened this issue May 24, 2019 · 1 comment
Closed

Generate wheels without python ABI #71

jcfr opened this issue May 24, 2019 · 1 comment
Assignees
@jcfr
Labels
Type: Enhancement Improvement to functionality

Comments

@jcfr
Copy link
Contributor

jcfr commented May 24, 2019

This will allow to:

  • be forward compatible with upcoming version of python
  • reduce the number of wheels to generate and upload on PyPi

For example, instead of

cmake-3.13.3-cp27-cp27m-manylinux1_i686.whl

wheels would be name like

cmake-X.Y.Z-py2.py3-none-manylinux2010_x86_64.whl

or

cmake-X.Y.Z-py2-none-manylinux2010_x86_64.whl
cmake-X.Y.Z-py3-none-manylinux2010_x86_64.whl

Generating one wheel for each py2 and py3 is a way to test used for both python2 and python3 with minimal effort.

See also scikit-build/scikit-build#420
@jcfr jcfr added the Type: Enhancement Improvement to functionality label May 24, 2019
@jcfr jcfr self-assigned this May 24, 2019
@jcfr jcfr mentioned this issue May 24, 2019
Closed
jcfr added a commit that referenced this issue May 26, 2019
@jcfr
Convert to generic platform wheel. See #71
af6fe8e
jcfr added a commit that referenced this issue May 26, 2019
@jcfr
Convert to generic platform wheel. See #71
b89eb41 
Uodate CI configuration to only build one wheel for each Python
version.
jcfr added a commit that referenced this issue May 26, 2019
@jcfr
Convert to generic platform wheel. See #71
27b9903 
Update CI configuration to only build one wheel for each Python
version.
jcfr added a commit that referenced this issue May 26, 2019
@jcfr
Convert to generic platform wheel. See #71
1240bd2 
Update CI configuration to only build one wheel for each Python
version.
jcfr added a commit that referenced this issue May 26, 2019
@jcfr
Merge pull request #72 from scikit-build/convert-to-generic-platform-…
d74ee54 
…wheel

Convert to generic platform wheel. See #71
@jcfr
Copy link
Contributor Author

jcfr commented May 26, 2019

Closing. Fixed in #72

@jcfr jcfr closed this as completed May 26, 2019
@jcfr jcfr mentioned this issue May 27, 2019
Closed
@jcfr jcfr added Category: ManyLinux Related to ManyLinux1 (PEP 513) and ManyLinux2010 (PEP 571) and removed Category: ManyLinux Related to ManyLinux1 (PEP 513) and ManyLinux2010 (PEP 571) labels May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfr jcfr

Labels
Type: Enhancement Improvement to functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcfr