Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruff and remove everything it replaces #68

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Add ruff and remove everything it replaces #68

merged 4 commits into from
Aug 23, 2024

Conversation

jschneidereit
Copy link
Contributor

@jschneidereit jschneidereit commented Jul 25, 2024 •
edited by imagejan
Loading

Closes #64.

@imagejan
Copy link
Member

I guess this still needs to be removed/replaced, otherwise flake will still bark:

scyjava/.github/workflows/build.yml

Lines 61 to 64 in bf5910e

- name: Flake code
run: |
python -m pip install flake8 Flake8-pyproject flake8-typing-imports
python -m flake8 src tests

@jschneidereit
Copy link
Contributor Author

Ah of course, missed a spot

@jschneidereit jschneidereit changed the title add ruff and remove everything it replaces draft: add ruff and remove everything it replaces Jul 25, 2024
@elevans elevans force-pushed the jschneidereit/64-add-ruff branch 5 times, most recently from c3c4d0e to a435a93 Compare July 29, 2024 16:27
@elevans
Bump openjdk version to 11
45cb752 
This commit resolves an unusual bug where pytest
fails to collect the results of the jep test, resulting
in failing CI jobs. I was able to reproduce this locally,
sometimes, with openjdk=8. There must be a race condition involved
with the bug as it doesn't always fail. The crash is a seg fault.
@elevans elevans changed the title draft: add ruff and remove everything it replaces Add ruff and remove everything it replaces Aug 23, 2024
@elevans
Move build dependency to pip section
2dcf3db 
Because we are no longer using the anaconda default
channel we need to obtain build from pypi.
@elevans
Copy link
Member

elevans commented Aug 23, 2024

Thanks @jschneidereit for this PR!

@elevans elevans merged commit d12410b into scijava:main Aug 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imagejan imagejan imagejan left review comments

@elevans elevans elevans left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switching linting infrastructure to ruff
3 participants
@jschneidereit @imagejan @elevans