Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml tests for some options #222

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

WilliamJamieson
Copy link
Contributor

@WilliamJamieson WilliamJamieson commented Sep 8, 2023

In astropy/astropy#15247 (comment), it was requested that pytest-doctestplus add unit testing to confirm the support of doctest_nocursedirs and doctest_subpackage_requires. This PR adds the requested tests.

Note that this PR requires bumping the minimum pytest version from 4.6 to 6. While this is a big jump it is inline with the Scientific Python Style Guide. In particular PP302 says that projects should use pytest 6 or later. Moreover, the method to test pyproject.toml files for pytest configuration, makepyprojecttoml, was only added in pytest 6.0.0.

I added skips on the test cases involving the pyproject.toml.

@WilliamJamieson WilliamJamieson marked this pull request as ready for review September 8, 2023 18:22
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Though I want Simon to have a chance to review since he originally brought up the concern.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that it doesn't bump the requirements (that would definitely be a blocker), it looks all good to me. Thanks!

@pllim pllim merged commit c93a231 into scientific-python:main Sep 11, 2023
@pllim
Copy link
Contributor

pllim commented Sep 11, 2023

Thanks, all!

@saimn
Copy link
Contributor

saimn commented Sep 21, 2023

Thanks for adding the tests @WilliamJamieson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants