-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject.toml tests for some options #222
Add pyproject.toml tests for some options #222
Conversation
ce9120a
to
81e69a9
Compare
81e69a9
to
4fa0e96
Compare
4fa0e96
to
1ce3cdb
Compare
1ce3cdb
to
55d803b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Though I want Simon to have a chance to review since he originally brought up the concern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that it doesn't bump the requirements (that would definitely be a blocker), it looks all good to me. Thanks!
Thanks, all! |
Thanks for adding the tests @WilliamJamieson. |
In astropy/astropy#15247 (comment), it was requested that
pytest-doctestplus
add unit testing to confirm the support ofdoctest_nocursedirs
anddoctest_subpackage_requires
. This PR adds the requested tests.Note that this PR requires bumping the minimumpytest
version from 4.6 to 6. While this is a big jump it is inline with the Scientific Python Style Guide. In particular PP302 says that projects should usepytest
6 or later. Moreover, the method to testpyproject.toml
files forpytest
configuration,makepyprojecttoml
, was only added inpytest 6.0.0
.I added skips on the test cases involving the
pyproject.toml
.