Replace tmpdir test fixture with tmp_path
#191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pytest` provides two fixtures for creating temporary directories: the recommended `tmp_path`, which uses `pathlib.Path` from the Python standard library, and the legacy `tmpdir`, which uses a third party library. The tests here now use `tmp_path` instead of `tmpdir`.
bsipocz
approved these changes
Oct 7, 2022
|
Thanks @eerovaher! As for the other update, I'm not sure we want to bump the minimum version to 6.2, yet. It's not yet out for 2 years, and the proposed changes are of very little benefit, while we have to be sure that our downstream will all be on pytest 6.2+ already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytestprovides two fixtures for creating temporary directories: the recommendedtmp_path, which usespathlib.Pathfrom the Python standard library, and the legacytmpdir, which uses a third party library. The tests here now usetmp_pathinstead oftmpdir.For the same reason the
testdirfixture should be replaced withpytester, but that would require the minimum supportedpytestversion to be 6.2.